[ 
https://issues.apache.org/jira/browse/HBASE-13569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516110#comment-14516110
 ] 

Hadoop QA commented on HBASE-13569:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12728527/HBASE-13569.1.patch
  against master branch at commit 2759fd0cdbb8aee928819c9d7306bb61c94126d8.
  ATTACHMENT ID: 12728527

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 
1910 checkstyle errors (more than the master's current 1898 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    + * public void myMethod(RpcController controller, MyRequest request, 
RpcCallback<MyResponse> done) {
+ * expression can contain visibility labels combined with logical operators 
AND(&), OR(|) and NOT(!)
+ * Cell implements Comparable<Cell> which is only meaningful when 
comparing to other keys in the
+   * memory size to give to the cache (if < 1.0) OR, it is the capacity in 
megabytes of the cache.
+ * <code>&lt;keylength&gt; &lt;valuelength&gt; &lt;key&gt; 
&lt;value&gt;</code> Key is further decomposed as:
+ * <code>&lt;rowlength&gt; &lt;row&gt; &lt;columnfamilylength&gt; 
&lt;columnfamily&gt; &lt;columnqualifier&gt;
+ * <code>&lt;taglength&gt;&lt;tagtype&gt;&lt;tagbytes&gt;</code>.  
<code>tagtype</code> is one byte and
+ * <code>&lt;hostname&gt; '{@link #SERVERNAME_SEPARATOR}' &lt;port&gt; '{@link 
#SERVERNAME_SEPARATOR}' &lt;startcode&gt;</code>.
+   * {@link 
org.apache.hadoop.hbase.master.SplitLogManagerCoordination#removeStaleRecoveringRegions(Set)}
+   * <code>void filterRow(List&lt;KeyValue&gt; kvs)</code> removing all the 
kvs from the passed List</li>

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.mapreduce.TestImportExport
                  org.apache.hadoop.hbase.util.TestProcessBasedCluster

     {color:red}-1 core zombie tests{color}.  There are 5 zombie test(s): 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13848//testReport/
Release Findbugs (version 2.0.3)        warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13848//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13848//artifact/patchprocess/checkstyle-aggregate.html

                Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13848//console

This message is automatically generated.

> correct errors reported with mvn site
> -------------------------------------
>
>                 Key: HBASE-13569
>                 URL: https://issues.apache.org/jira/browse/HBASE-13569
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Gabor Liptak
>            Priority: Minor
>         Attachments: HBASE-13569.1.patch, HBASE-13569.patch
>
>
> There are a number of Javadoc errors reported when running mvn site.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to