[
https://issues.apache.org/jira/browse/HBASE-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516339#comment-14516339
]
Anoop Sam John commented on HBASE-13358:
----------------------------------------
Thanks for detail look Srikanth.
bq.Without patch, we're using connection with system user as default. But this
changes is making use of
Any specific reason? I think it was just to make sure to use some existing
connection and for that just created a super connection at first. If it is just
for this purpose I am ok with any.
bq.But the nice thing with the approach in the patch is it reuses connections!
Which tradeoff (extensibility vs perf) should we make?
This is test and we wont take much time running them. Am also tend towards your
thinking Srikanth. We better make connection there and pass them.
Similar way for the above also.
> Upgrade VisibilityClient API to accept Connection object.
> ---------------------------------------------------------
>
> Key: HBASE-13358
> URL: https://issues.apache.org/jira/browse/HBASE-13358
> Project: HBase
> Issue Type: Improvement
> Reporter: Srikanth Srungarapu
> Assignee: Matt Warhaftig
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-13358.patch, HBASE-13358_v2.patch
>
>
> From VisibilityClient class:
> {code}
> // TODO: Make it so caller passes in a Connection rather than have us do
> this expensive
> // setup each time. This class only used in test and shell at moment
> though.
> {code}
> Basically, this is the VC's counterpart of HBASE-13171.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
