[
https://issues.apache.org/jira/browse/HBASE-13351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14517198#comment-14517198
]
Josh Elser commented on HBASE-13351:
------------------------------------
bq. whether the configs to do with metahandler count and the handler threads
that are changed in the various tests should instead be put in the
hbase-site.xml that we have for tests (e.g.,
hbase-server/src/test/resources/hbase-site.xml)
Oh, how about that. I wasn't aware of that configuration file :). The drawback
would be increasing the thread footprint of tests that don't need the larger
thread pools. It would help from test cluster consistency so that may be worth
it. Happy to do it if you think it's worth it.
bq. Any way we can write a FT test to assert that the RS->Master APIs are
treated with higher priority. I see your UT for asserting the annotation. Not
blocking for commit though.
Sure, I'd be happy to try to verify that. I'm not sure of the best way off the
top of my head, maybe mock out the thread pools for each handler and spoof some
calls and make sure they hit the right pools? I'll file a follow-on to make
sure this doesn't get lost.
Thanks for the reviews, [~devaraj] and [~anoop.hbase]!
> Annotate internal MasterRpcServices methods with admin priority
> ---------------------------------------------------------------
>
> Key: HBASE-13351
> URL: https://issues.apache.org/jira/browse/HBASE-13351
> Project: HBase
> Issue Type: Improvement
> Components: master
> Reporter: Josh Elser
> Assignee: Josh Elser
> Fix For: 2.0.0, 1.1.0, 1.2.0
>
> Attachments: HBASE-13351-v1.patch, HBASE-13351-v2.patch,
> HBASE-13351-v3.patch, HBASE-13351-v4.patch, HBASE-13351-v5.patch,
> HBASE-13351.patch
>
>
> HBASE-12071, among other things, introduced annotating RPC methods to give
> certain methods priority over others. Namely, this helps ensure that client
> requests cannot starve out internal RPC between master and regionserver.
> Similarly, we can do the same thing for Master RPC methods that are invoked
> by RS's.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
