[ https://issues.apache.org/jira/browse/HBASE-13431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14517576#comment-14517576 ]
Enis Soztutar commented on HBASE-13431: --------------------------------------- The patch makes sense. In some offline discussion, it was not clear whether RegionSplitPolicy is a valid extension point or not. If we are concerned about supporting users who implemented it, I think we can deprecate the method and introduce the override. > Move splitStoreFile to SplitTransaction interface to allow creating both > reference files in case required > --------------------------------------------------------------------------------------------------------- > > Key: HBASE-13431 > URL: https://issues.apache.org/jira/browse/HBASE-13431 > Project: HBase > Issue Type: Improvement > Reporter: Rajeshbabu Chintaguntla > Assignee: Rajeshbabu Chintaguntla > Fix For: 2.0.0, 1.1.0 > > Attachments: HBASE-13431.patch, HBASE-13431_v2.patch, > HBASE-13431_v3.patch > > > APPROACH #3 at PHOENIX-1734 helps to implement local indexing without much > changes in HBase. For split we need one kernel change to allow creating both > top and bottom reference files for index column family store files even when > the split key not in the storefile key range. > The changes helps in this case are > 1) pass boolean to HRegionFileSystem#splitStoreFile to allow to skip the > storefile key range check. > 2) move the splitStoreFile with extra boolean parameter to the new interface > introduced at HBASE-12975. -- This message was sent by Atlassian JIRA (v6.3.4#6332)