[ 
https://issues.apache.org/jira/browse/HBASE-13431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518139#comment-14518139
 ] 

Hadoop QA commented on HBASE-13431:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12728936/HBASE-13054_branch-1.0.patch
  against branch-1.0 branch at commit ee562faeb3cd0b7a49a1319fdc775f1d43e32341.
  ATTACHMENT ID: 12728936

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13872//console

This message is automatically generated.

> Allow to skip store file range check based on column family while creating 
> reference files in HRegionFileSystem#splitStoreFile
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13431
>                 URL: https://issues.apache.org/jira/browse/HBASE-13431
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Rajeshbabu Chintaguntla
>            Assignee: Rajeshbabu Chintaguntla
>             Fix For: 2.0.0, 1.1.0
>
>         Attachments: HBASE-13054_branch-1.0.patch, HBASE-13431.patch, 
> HBASE-13431_branch-1.1.patch, HBASE-13431_branch-1.patch, 
> HBASE-13431_v2.patch, HBASE-13431_v3.patch, HBASE-13431_v4.patch
>
>
>  APPROACH #3 at PHOENIX-1734 helps to implement local indexing without much 
> changes in HBase. For split we need one kernel change to allow creating both 
> top and bottom reference files for index column family store files even when 
> the split key not in the storefile key range. 
> The changes helps in this case are  
> 1) pass boolean to HRegionFileSystem#splitStoreFile to allow to skip the 
> storefile key range check.
> 2) move the splitStoreFile with extra boolean parameter  to the new interface 
> introduced at HBASE-12975. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to