[ 
https://issues.apache.org/jira/browse/HBASE-13312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14524358#comment-14524358
 ] 

Hadoop QA commented on HBASE-13312:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12729846/HBASE-13312-0.98.patch
  against 0.98 branch at commit 8bffd45bd50abd36c196f6d79ced5d8ba1cd2042.
  ATTACHMENT ID: 12729846

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 12 new 
or modified tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 
25 warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 
3835 checkstyle errors (more than the master's current 3834 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

     {color:red}-1 core zombie tests{color}.  There are 5 zombie test(s):       
at 
org.apache.hadoop.hbase.io.encoding.TestEncodedSeekers.testEncodedSeeker(TestEncodedSeekers.java:121)
        at 
org.apache.hadoop.hbase.io.encoding.TestChangingEncoding.testChangingEncoding(TestChangingEncoding.java:203)
        at 
org.apache.hadoop.hbase.io.encoding.TestDataBlockEncoders.testSeekingOnSample(TestDataBlockEncoders.java:204)
        at 
org.apache.hadoop.hbase.mapred.TestTableSnapshotInputFormat.testWithMapReduceImpl(TestTableSnapshotInputFormat.java:215)
        at 
org.apache.hadoop.hbase.mapreduce.TableSnapshotInputFormatTestBase.testWithMapReduce(TableSnapshotInputFormatTestBase.java:111)
        at 
org.apache.hadoop.hbase.mapred.TestTableSnapshotInputFormat.testWithMapReduceAndOfflineHBaseMultiRegion(TestTableSnapshotInputFormat.java:147)

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13924//testReport/
Release Findbugs (version 2.0.3)        warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13924//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13924//artifact/patchprocess/checkstyle-aggregate.html

                Javadoc warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13924//artifact/patchprocess/patchJavadocWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13924//console

This message is automatically generated.

> SmallScannerCallable does not increment scan metrics
> ----------------------------------------------------
>
>                 Key: HBASE-13312
>                 URL: https://issues.apache.org/jira/browse/HBASE-13312
>             Project: HBase
>          Issue Type: Bug
>          Components: Client, Scanners
>    Affects Versions: 1.0.0
>            Reporter: Lars George
>            Assignee: Andrew Purtell
>             Fix For: 2.0.0, 0.98.13, 1.0.2, 1.2.0, 1.1.1
>
>         Attachments: HBASE-13312-0.98.patch, HBASE-13312.patch
>
>
> The subclass of {{ScannerCallable}}, called {{SmallScannerCallable}} seems to 
> miss calling any of the increment methods of the {{ScanMetrics}}. The 
> superclass does so, but the super methods are not invoked. It emits the 
> metrics dutifully at the end of {{next()}}, but there are no useful numbers 
> in it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to