[ 
https://issues.apache.org/jira/browse/HBASE-13571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525754#comment-14525754
 ] 

Matteo Bertozzi commented on HBASE-13571:
-----------------------------------------

getOperationType()/getDescription() looks great.

I don't think the modifyTable wait without proc-response is correct.
{code}
+    protected Void waitOperationResult(final long deadlineTs) ...
+      waitForTableEnabled(deadlineTs);
+      return null;
+    }
{code}
as far as I know modify doesn't enable the table back in case of disable,
and in case of table enabled the table is already enabled. 
I think you have two options, assume that you always have a proc-result. 
so no need to implement this, or you have to add some if was disabled/enabled
and handle this. also, in that case we probably don't have the information yet
from the RSs to know that the HTD was updated. maybe something that we can do 
later
when the notification-bus is ready.

> Procedure v2 - client modify table sync
> ---------------------------------------
>
>                 Key: HBASE-13571
>                 URL: https://issues.apache.org/jira/browse/HBASE-13571
>             Project: HBase
>          Issue Type: Sub-task
>          Components: proc-v2
>            Reporter: Srikanth Srungarapu
>            Assignee: Srikanth Srungarapu
>            Priority: Minor
>         Attachments: HBASE-13571.patch
>
>
> Client side part of HBASE-13210. 
> It uses the new procedure code to be know when the procedure is completed, 
> and have a proper sync/async behavior on modify table.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to