[ 
https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14526941#comment-14526941
 ] 

Andrew Purtell commented on HBASE-13014:
----------------------------------------

[~lhofhansl] and I had a look at the latest patch and have the following 
suggestions:
- Introduce an option which is the total time the tool should run. Don't use 
potentially infinite loops or APIs that do not time out. Make sure the tool can 
exit at the desired total execution time if that option is presented. This is 
for use cases where we only want the tool to be best effort.
- Wait for the thread pools to finish, with timeout, using awaitTermination, 
instead of blocking (potentially for a very long time) on Future#get of each 
submitted task. 
- There are APIs available in HTable and HConnection for getting region 
locations that do not require instantiation of a ZK tracker and the other low 
level stuff done there. Prefer you use the former. 

> Java Tool For Region Moving 
> ----------------------------
>
>                 Key: HBASE-13014
>                 URL: https://issues.apache.org/jira/browse/HBASE-13014
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Abhishek Singh Chouhan
>            Assignee: Abhishek Singh Chouhan
>             Fix For: 2.0.0, 0.98.13, 1.2.0
>
>         Attachments: HBASE-13014-v2.patch, HBASE-13014-v3.patch, 
> HBASE-13014-v4.patch, HBASE-13014-v5.patch, HBASE-13014.patch
>
>
> As per discussion on HBASE-12989 we should move the functionality of 
> region_mover.rb into a Java tool and use region_mover.rb only only as a 
> wrapper around it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to