[ 
https://issues.apache.org/jira/browse/HBASE-13562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14529734#comment-14529734
 ] 

Srikanth Srungarapu commented on HBASE-13562:
---------------------------------------------

Thanks a lot for picking this up!
bq. Also I feel its better to break this jira based on the ACL matric 
interface, so that developing and reviewing the patch also becomes easy.
Sure, this makes sense. Go ahead with it. Feel free to create the sub-tasks and 
work on them too if interested.
bq. Please review and let me know your thought, based on that I will move this 
jira into Patch Available state.
Skimmed the patch. Looking good. Also one more thing,  in HBASE-13359 we added 
the missing table owner. Haven't pushed the changes to website yet. You might 
want to factor that in. 

> Expand AC testing coverage to include all combinations of scope and 
> permissions.
> --------------------------------------------------------------------------------
>
>                 Key: HBASE-13562
>                 URL: https://issues.apache.org/jira/browse/HBASE-13562
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Srikanth Srungarapu
>            Assignee: Ashish Singhi
>         Attachments: HBASE-13562.patch
>
>
> As of now, the tests in TestAccessController and TestAccessController2 
> doesn't cover all the combinations of Scope and Permissions. Ideally, we 
> should have testing coverage for the entire [ACL 
> matrix|https://hbase.apache.org/book/appendix_acl_matrix.html].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to