[
https://issues.apache.org/jira/browse/HBASE-13606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14530822#comment-14530822
]
Hadoop QA commented on HBASE-13606:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12730826/HBASE-13606-v3.patch
against master branch at commit 652929c0ff8c8cec1e86ded834f3e770422b2ace.
ATTACHMENT ID: 12730826
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13963//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13963//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13963//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13963//console
This message is automatically generated.
> AssignmentManager.assign() is not sync in both path
> ---------------------------------------------------
>
> Key: HBASE-13606
> URL: https://issues.apache.org/jira/browse/HBASE-13606
> Project: HBase
> Issue Type: Bug
> Components: Region Assignment
> Affects Versions: 2.0.0, 1.1.0, 1.2.0
> Reporter: Matteo Bertozzi
> Assignee: Matteo Bertozzi
> Fix For: 2.0.0, 1.1.0, 1.2.0
>
> Attachments: HBASE-13606-v0.patch, HBASE-13606-v1-branch-1.patch,
> HBASE-13606-v1.patch, HBASE-13606-v2-branch-1.patch, HBASE-13606-v2.patch,
> HBASE-13606-v3.patch,
> TEST-org.apache.hadoop.hbase.master.procedure.TestCreateTableProcedure.xml
>
>
> from the comment and the expected behavior AssignmentManager.assign() should
> be sync
> {code}
> /** Assigns specified regions round robin, if any.
> * This is a synchronous call and will return once every region has been
> public void assign(List<HRegionInfo> regions)
> {code}
> but the code has two path. 1 sync and the async
> {code}
> if (servers == 1 || (regions < bulkAssignThresholdRegions
> && servers < bulkAssignThresholdServers)) {
> for (HRegionInfo region: plan.getValue()) {
> ...
> invokeAssign(region); // <-- this is async threadPool.submit(assign)
> ...
> }
> } else {
> BulkAssigner ba = new GeneralBulkAssigner(...);
> ba.bulkAssign(); // <-- this is sync, calls BulkAssign.waitUntilDone()
> }
> {code}
> https://builds.apache.org/job/HBase-1.1/452/ TestCreateTableProcedure is
> flaky because of this async behavior
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
