[ 
https://issues.apache.org/jira/browse/HBASE-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14530833#comment-14530833
 ] 

Hadoop QA commented on HBASE-1989:
----------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12730830/HBASE-1989-v1.patch
  against master branch at commit 652929c0ff8c8cec1e86ded834f3e770422b2ace.
  ATTACHMENT ID: 12730830

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 58 new 
or modified tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13962//testReport/
Release Findbugs (version 2.0.3)        warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13962//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13962//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13962//console

This message is automatically generated.

> Admin (et al.) not accurate with Column vs. Column-Family usage
> ---------------------------------------------------------------
>
>                 Key: HBASE-1989
>                 URL: https://issues.apache.org/jira/browse/HBASE-1989
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.20.1, 0.90.1
>            Reporter: Doug Meil
>            Assignee: Lars Francke
>            Priority: Minor
>         Attachments: HBASE-1989-v1.patch, HBASE-1989.patch, hbase1989.patch
>
>
> Consider the classes Admin and HColumnDescriptor.
> HColumnDescriptor is really referring to a "column family" and not a "column" 
> (i.e., family:qualifer).
> Likewise, in Admin there is a method called "addColumn" that takes an 
> HColumnDescriptor instance.
> I labeled this a bug in the sense that it produces conceptual confusion 
> because there is a big difference between a column and column-family in HBase 
> and these terms should be used consistently.  The code works, though.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to