[
https://issues.apache.org/jira/browse/HBASE-13634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14531048#comment-14531048
]
Lars Francke commented on HBASE-13634:
--------------------------------------
Yeah I'm not sure either. But even just the fact that you can't remember
warrants a patch IMHO. Either a solid explanation why it's not needed or
switching to the safe variant. {{Arrays.equals}} does a reference check as well
and I assume it's small enough to be inlined so the overhead should be minimal.
> Unsafe reference equality checks to EMPTY_START_ROW
> ---------------------------------------------------
>
> Key: HBASE-13634
> URL: https://issues.apache.org/jira/browse/HBASE-13634
> Project: HBase
> Issue Type: Bug
> Components: Compaction, Scanners
> Reporter: Dave Latham
> Attachments: HBASE-13634.patch
>
>
> While looking to see if there was a standard method in the code base for
> testing for the empty start and end row, I noticed some cases that are using
> unsafe reference equality checks and thus may have incorrect behavior in
> boundary cases:
> ScanQueryMatcher.checkPartialDropDeleteRange
> StripeStoreFileManager.findStripeForRow
> It looks like both are intended to support stripe compaction
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
