[
https://issues.apache.org/jira/browse/HBASE-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14532079#comment-14532079
]
Hadoop QA commented on HBASE-13641:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12731072/HBASE-13641.patch
against master branch at commit 11b76732c0ec80a2cccbe7937440bd107e577c8b.
ATTACHMENT ID: 12731072
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
1899 checkstyle errors (more than the master's current 1896 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.filter.TestRandomRowFilter
org.apache.hadoop.hbase.filter.TestInclusiveStopFilter
org.apache.hadoop.hbase.filter.TestFilterList
org.apache.hadoop.hbase.filter.TestFilter
org.apache.hadoop.hbase.filter.TestPrefixFilter
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.camel.component.file.FileProducerFileExistAppendNoFileBeforeTest.testAppend(FileProducerFileExistAppendNoFileBeforeTest.java:42)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13969//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13969//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13969//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13969//console
This message is automatically generated.
> Deperecate Filter#filterRowKey(byte[] buffer, int offset, int length) in
> favor of filterRowKey(Cell firstRowCell)
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-13641
> URL: https://issues.apache.org/jira/browse/HBASE-13641
> Project: HBase
> Issue Type: Sub-task
> Components: Filters, regionserver, Scanners
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Fix For: 2.0.0
>
> Attachments: HBASE-13641.patch
>
>
> This is in path towards HBASE-13387
> When the scan contains any filter, we have to call the
> filterRowKey(byte[],int,int) API. (Even if it is not interested in this
> method)
> When the Cells coming in is offheap backed, we would need temp byte[]
> creation and copy row bytes to that. If we can make this Filter API to take
> a cell (which is the first cell in any row), we can avoid this overhead.
> In 2.0.0 we will deprecate the old API with addition of new and FilterBase
> will give BC for old style custom Filters.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
