[
https://issues.apache.org/jira/browse/HBASE-13562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537307#comment-14537307
]
Srikanth Srungarapu commented on HBASE-13562:
---------------------------------------------
bq. There are some unused variables in
{{TestAccessControllerNonMasterAndRSOps}} we can remove them.
Let's take care of this in HBASE-13644, as this jira is only for master and RS
ops.
bq. There are some deprecated methods being used better we can remove them now.
Besides {{setOwner}}, no deprecated methods are in
{{TestAccessControllerMasterAndRSOps}}. For
{{TestAccessControllerNonMasterAndRSOps}}, like I said let's take care of it in
HBASE-13644.
bq. modified the test accordingly locally I saw that the test run time was 3x
times better! I thought of contributing this as part of other jira as it was
out of this jira scope.
This is a great find! Aside this change being out of scope for this jira, I
would really prefer you to file a separate issue and work on it, so that you
can get the due credit.
> Rejigger AC tests and expand testing coverage for master/RS ops to include
> all scope and permissoin combinations.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-13562
> URL: https://issues.apache.org/jira/browse/HBASE-13562
> Project: HBase
> Issue Type: Improvement
> Reporter: Srikanth Srungarapu
> Assignee: Ashish Singhi
> Attachments: HBASE-13562-v1.patch, HBASE-13562-v2.patch,
> HBASE-13562.patch, HBASE-13562_v2.patch, sample.patch
>
>
> As of now, the tests in TestAccessController and TestAccessController2
> doesn't cover all the combinations of Scope and Permissions. Ideally, we
> should have testing coverage for the entire [ACL
> matrix|https://hbase.apache.org/book/appendix_acl_matrix.html].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
