[ 
https://issues.apache.org/jira/browse/HBASE-13661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538944#comment-14538944
 ] 

Nick Dimiduk commented on HBASE-13661:
--------------------------------------

Here's the compat report I get with this patch applied to the next rc, with 
line-by-line comments:

bq. removed methods, ServerLoad

[~enis] justified these in his above comment.

bq. removed methods, AuthUtil

Made private by this patch

bq. removed methods, AccessController

This class is LimitedPrivate(HBaseInterfaceAudience.CONFIG)

bq. removed methods, ReplicationEndpoint.Context

Class is LimitedPrivate(HBaseInterfaceAudience.REPLICATION); the constructor 
itself is marked a Private.

bq. removed methods, RegionObserver

These are related to the new Region interface, acceptable.

bq. removed methods, RegionScanner

This class is marked Evolving and is 
LimitedPrivate(HBaseInterfaceAudience.COPROC), so this change is acceptable.

bq. Problems with Data Types, High Severity, ZooKeeperWatcher

This class is Private; recompilation from 1.0.x to 1.1.x is excepted.

bq. Problems with Data Types, High Severity, RegionObserver

Already mentioned, above.

bq. Problems with Data Types, High Severity, HRegion

This class is Private; recompilation from 1.0.x to 1.1.x is excepted.

bq. Problems with Data Types, High Severity, HRegionServer

LimitedPrivate(HBaseInterfaceAudience.TOOLS); recompilation expected.

bq. Problems with Data Types, High Severity, RegionScanner

Addressed above

bq. Problems with Methods, High Severity, HMaster

Class is restricted to LimitedPrivate(HBaseInterfaceAudience.TOOLS)

bq. Problems with Methods, High Severity, Store

Class is Evolving, change permitted.

bq. Problems with Data Types, Medium Severity, RpcServerInterface

Recompilation is expected.

bq. Problems with Data Types, Medium Severity, RegionScanner

Recompilation is expected.

bq. Other Changes in Data Types

All these are added methods, which is permitted in minor releases.

http://people.apache.org/~ndimiduk/1.0.1_branch-1.1.0_compat_report.html#Binary_Removed

+1

> Correct binary compatibility issues discovered in 1.1.0RC0
> ----------------------------------------------------------
>
>                 Key: HBASE-13661
>                 URL: https://issues.apache.org/jira/browse/HBASE-13661
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 2.0.0, 1.1.0, 1.2.0
>
>         Attachments: hbase-13661_v1-branch-1.1.patch
>
>
> Over on the 1.1.0RC0 VOTE thread, Enis discovered some errors in 
> InterfaceAudience annotations. Let's fix them.
> Filed by [~ndimiduk] on [~enis]'s behalf.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to