[
https://issues.apache.org/jira/browse/HBASE-13646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14543910#comment-14543910
]
Hadoop QA commented on HBASE-13646:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12732840/HBASE-13646-branch-1.patch
against branch-1 branch at commit 9ba7337ac82d13b22a1b0c40edaba7873c0bd795.
ATTACHMENT ID: 12732840
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 12 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14046//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14046//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14046//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14046//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14046//console
This message is automatically generated.
> HRegion#execService should not try to build incomplete messages
> ---------------------------------------------------------------
>
> Key: HBASE-13646
> URL: https://issues.apache.org/jira/browse/HBASE-13646
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, regionserver
> Affects Versions: 2.0.0, 1.2.0, 1.1.1
> Reporter: Andrey Stepachev
> Assignee: Andrey Stepachev
> Fix For: 2.0.0
>
> Attachments: HBASE-13646-branch-1.patch, HBASE-13646.patch,
> HBASE-13646.v2.patch, HBASE-13646.v2.patch
>
>
> If some RPC service, called on region throws exception, execService still
> tries to build Message. In case of complex messages with required fields it
> complicates service code because service need to pass fake protobuf objects,
> so they can be barely buildable.
> To mitigate that I propose to check that controller was failed and return
> null from call instead of failing with exception.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
