[ 
https://issues.apache.org/jira/browse/HBASE-13531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545174#comment-14545174
 ] 

Anoop Sam John commented on HBASE-13531:
----------------------------------------

The logic is fine
{code}
result = scanner.peek();
+          if (result.getSequenceId() > readPt) {
+            // current cell is invisible, look for the next.
+            Cell candidate = scanner.next();
+            while (candidate != null) {
+              if (CellComparator.compare(search, candidate, true) != 0) {
+                break;
+              }
{code}
We return result right?  So if there are no match and the break happens, we 
will return the 1st cell. Ideally this will never happen. Still for the 
correctness we should not return the 1st Cell.(null is ok?)
bq.Because we don't reset the seqId in compactions.
May be we can follow the same logic like when the cell seqId is less than 
smallest readpoint, we can reset it to 0.


> After 4/18/15 merge, flakey failures of 
> TestAcidGuarantees#testMobScanAtomicity
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-13531
>                 URL: https://issues.apache.org/jira/browse/HBASE-13531
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>    Affects Versions: hbase-11339
>            Reporter: Jonathan Hsieh
>             Fix For: hbase-11339
>
>         Attachments: HBASE-13531-V2.diff, HBASE-13531.diff
>
>
> After the merge of master from 4/18/15 with hbase-11339 branch, we encounter 
> some atomicity violations.  We want to fix before calling merge to trunk.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to