[
https://issues.apache.org/jira/browse/HBASE-13700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14546515#comment-14546515
]
Hadoop QA commented on HBASE-13700:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12733276/HBASE-13700.patch
against master branch at commit 88f0f421c3330f4ba914ecf89d8d2afe78cacbc4.
ATTACHMENT ID: 12733276
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ InetSocketAddress
inetSocketAddress) throws TTransportException {
+ server = getTHsHaServer(protocolFactory, processor, transportFactory,
workerThreads, inetSocketAddress, metrics);
+ server = getTThreadPoolServer(protocolFactory, processor,
transportFactory, workerThreads, inetSocketAddress);
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14062//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14062//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14062//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14062//console
This message is automatically generated.
> Allow Thrift2 HSHA server to have configurable threads
> ------------------------------------------------------
>
> Key: HBASE-13700
> URL: https://issues.apache.org/jira/browse/HBASE-13700
> Project: HBase
> Issue Type: Bug
> Components: Thrift
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-13700-v1.patch, HBASE-13700.patch
>
>
> The half sync half async server by default starts 5 worker threads. For busy
> servers that might not be enough. That should be configurable.
> For the threadpool there should be a way to set the max number of threads so
> that creating threads doesn't run away. That should be configurable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
