[ 
https://issues.apache.org/jira/browse/HBASE-13673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14547528#comment-14547528
 ] 

Matteo Bertozzi commented on HBASE-13673:
-----------------------------------------

looks good to me.

you can probably change the below
{code}
LOG.debug("Remove all state logs with ID less than " + lastLogId);
while (!logs.isEmpty()) {
{code}
with an if (logs.isEmpty()) return which should be the most common case.
{code}
if (logs.size() <= 1) {
  // we only have the active log running
  assert logs.size() > 0;
  return;
}
LOG.debug("Remove all state logs with ID less than " + lastLogId);
do {
  ..
} while (!logs.isEmpty())
{code}


> WALProcedureStore procedure is chatty
> -------------------------------------
>
>                 Key: HBASE-13673
>                 URL: https://issues.apache.org/jira/browse/HBASE-13673
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0, 1.1.0
>            Reporter: Andrew Purtell
>            Assignee: Srikanth Srungarapu
>            Priority: Minor
>         Attachments: HBASE-13673.patch
>
>
> Lots of procedure logging at INFO level which should be at DEBUG, especially 
> "Remove all state logs with ID less then 0". 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to