[
https://issues.apache.org/jira/browse/HBASE-13675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14547580#comment-14547580
]
Ashish Singhi commented on HBASE-13675:
---------------------------------------
lgtm.
one minor nit,
Can we enclose this within isDebugEnabled check, as it involves some
computation.
{code}
676 LOG.debug("Procedure completed in " +
677 StringUtils.humanTimeDiff(proc.elapsedTime()) + ": " +
proc);
{code}
> ProcedureExecutor completion report should be at DEBUG log level
> ----------------------------------------------------------------
>
> Key: HBASE-13675
> URL: https://issues.apache.org/jira/browse/HBASE-13675
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 2.0.0, 1.1.0
> Reporter: Andrew Purtell
> Assignee: Srikanth Srungarapu
> Priority: Minor
> Attachments: HBASE-13675.patch
>
>
> Example:
> {noformat}
> 2015-05-12 12:05:03,445 INFO [ProcedureExecutorThread-0]
> procedure2.ProcedureExecutor: Procedure completed in 838msec:
> EnableTableProcedure (table=cluster_test) user=apurtell (auth:SIMPLE) id=5
> state=FINISHED
> {noformat}
> The procedures themselves are already emitting task specific information at
> INFO level. This doesn't add much information besides the elapsed time, so
> probably should be at DEBUG level. I assume if a procedure fails there will
> be additional logging at WARN level, but if not, that could be a
> consideration.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
