[
https://issues.apache.org/jira/browse/HBASE-13582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14551297#comment-14551297
]
Hadoop QA commented on HBASE-13582:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12733943/HBASE-13582.patch
against master branch at commit 74e5b26e57ef8d31723ff05ff913bad7f92a7518.
ATTACHMENT ID: 12733943
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+0 tests included{color}. The patch appears to be a
documentation patch that doesn't require tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+link:https://issues.apache.org/jira/browse/HBASE-6449[HBASE-6449] added
support for tracing requests through HBase, using the open source tracing
library, link:http://htrace.incubator.apache.org/[HTrace].
+The tracing system works by collecting information in structures called
'Spans'. It is up to you to choose how you want to receive this information by
implementing the `SpanReceiver` interface, which defines one method:
+HTrace also provides `ZipkinSpanReceiver` which converts spans to
link:http://github.com/twitter/zipkin[Zipkin] span format and send them to
Zipkin server. In order to use this span receiver, you need to install the jar
of htrace-zipkin to your HBase's classpath on all of the nodes in your cluster.
+_htrace-zipkin_ is published to the
link:http://search.maven.org/#search%7Cgav%7C1%7Cg%3A%22org.apache.htrace%22%20AND%20a%3A%22htrace-zipkin%22[Maven
central repository]. You could get the latest version from there or just build
it locally (see the link:http://htrace.incubator.apache.org/[HTrace] homepage
for information on how to do this) and then copy it out to all nodes.
+`ZipkinSpanReceiver` for properties called
`hbase.htrace.zipkin.collector-hostname` and
`hbase.htrace.zipkin.collector-port` in _hbase-site.xml_ with values describing
the Zipkin collector server to which span information are sent.
+If you do not want to use the included span receivers, you are encouraged to
write your own receiver (take a look at `LocalFileSpanReceiver` for an
example). If you think others would benefit from your receiver, file a JIRA
with the HTrace project.
+You can use `trace` command for tracing requests from HBase Shell. `trace
'start'` command turns on tracing and `trace 'stop'` command turns off tracing.
+`trace 'start'` and `trace 'stop'` always returns boolean value representing
if or not there is ongoing tracing.
+As a result, `trace 'stop'` returns false on success. `trace 'status'` just
returns if or not tracing is turned on.
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.hadoop.hbase.ResourceCheckerJUnitListener.testStarted(ResourceCheckerJUnitListener.java:178)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14097//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14097//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14097//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14097//console
This message is automatically generated.
> Update docs for HTrace
> ----------------------
>
> Key: HBASE-13582
> URL: https://issues.apache.org/jira/browse/HBASE-13582
> Project: HBase
> Issue Type: Task
> Components: documentation
> Reporter: Sean Busbey
> Assignee: Lars Francke
> Priority: Minor
> Labels: beginner
> Attachments: HBASE-13582.patch
>
>
> the ref guide currently points to HTrace at its old location. update it to
> point at the ASF project. Should also verify that the usage example is still
> correct.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)