[
https://issues.apache.org/jira/browse/HBASE-13726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14553205#comment-14553205
]
Hadoop QA commented on HBASE-13726:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12734198/HBASE-13726.1.patch
against master branch at commit 77d9719e2bd7db20b0ad3bafb255c9d797d2b49d.
ATTACHMENT ID: 12734198
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at org.apache.hadoop.mapred.TestMerge.testMerge(TestMerge.java:87)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14123//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14123//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14123//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14123//console
This message is automatically generated.
> stop using Hadoop's IOUtils
> ---------------------------
>
> Key: HBASE-13726
> URL: https://issues.apache.org/jira/browse/HBASE-13726
> Project: HBase
> Issue Type: Task
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Attachments: HBASE-13726.1.patch
>
>
> In HBaseFsck we make use of Hadoop's IOUtils for ignore-errors-while-closing.
> All of these methods (in the way we call them) behave the same as
> commons-io's IOUtils.closeQuietly. One of the methods in the Hadoop version
> also uses a parameter that isn't in org.apache.hadoop.
> We already have commons-io as a dependency in this module, we should just use
> the commons-io version since it is stable and more limited in surface.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
