[ 
https://issues.apache.org/jira/browse/HBASE-13729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14553256#comment-14553256
 ] 

Esteban Gutierrez commented on HBASE-13729:
-------------------------------------------

hbase.regionserver.global.memstore.upperLimit has the same problem, we have 
hbase.regionserver.global.memstore.size.lower.limit defined in hbase-defaul.xml 
and we will return immediately in getGlobalMemStoreLowerMark() instead of using 
the lower limit if present.

> Old hbase.regionserver.global.memstore.upperLimit is ignored if present
> -----------------------------------------------------------------------
>
>                 Key: HBASE-13729
>                 URL: https://issues.apache.org/jira/browse/HBASE-13729
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 2.0.0, 1.0.1, 1.1.0
>            Reporter: Esteban Gutierrez
>            Assignee: Esteban Gutierrez
>            Priority: Critical
>         Attachments: 
> 0001-HBASE-13729-Old-hbase.regionserver.global.memstore.u.patch
>
>
> If hbase.regionserver.global.memstore.upperLimit is present we should use it 
> instead of hbase.regionserver.global.memstore.size the current implementation 
> of HeapMemorySizeUtil.getGlobalMemStorePercent() asumes that if 
> hbase.regionserver.global.memstore.size is not defined thenit should use the 
> old configuration, however it should be the other way around.
> This has a large impact specially if doing a rolling upgrade of a cluster 
> when the memstore upper limit has been changed from the default.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to