[
https://issues.apache.org/jira/browse/HBASE-13736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14553755#comment-14553755
]
Anoop Sam John commented on HBASE-13736:
----------------------------------------
Patch looks good except a minor comment
{code}
- super(master.getServerName() + "-ExpiredMobFileCleanerChore", master,
- master.getConfiguration().getInt(MobConstants.MOB_CLEANER_PERIOD,
- MobConstants.DEFAULT_MOB_CLEANER_PERIOD));
+ super(master.getServerName() + "-ExpiredMobFileCleanerChore", master,
master.getConfiguration()
+ .getInt(MobConstants.MOB_CLEANER_PERIOD,
MobConstants.DEFAULT_MOB_CLEANER_PERIOD), master
+ .getConfiguration().getInt(MobConstants.MOB_CLEANER_PERIOD,
+ MobConstants.DEFAULT_MOB_CLEANER_PERIOD), TimeUnit.SECONDS);
{code}
Can you get the delay from conf just once and use it as 2 args?
> Add delay for the first execution of ExpiredMobFileCleanerChore and
> MobFileCompactorChore
> -----------------------------------------------------------------------------------------
>
> Key: HBASE-13736
> URL: https://issues.apache.org/jira/browse/HBASE-13736
> Project: HBase
> Issue Type: Sub-task
> Components: mob
> Affects Versions: hbase-11339
> Reporter: Jingcheng Du
> Assignee: Jingcheng Du
> Fix For: hbase-11339
>
> Attachments: HBASE-13736.diff
>
>
> Currently, the ExpiredMobFileCleanerChore and MobFileCompactorChore are
> executed immediately when the master is started. At that time most of regions
> are not online, running these chore is a waste. We need to add a delay for
> them, now in the patch, we will use the interval as the initial delay.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
