[
https://issues.apache.org/jira/browse/HBASE-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554066#comment-14554066
]
Ashish Singhi commented on HBASE-13658:
---------------------------------------
Thanks [~apurtell] for the review.
bq. ◾The table delete for cleaning up after testMergeRegions should be in the
finally part of a try-finally wrapping the code after table create succeeds.
Addressed.
bq. ◾The disable and re-enable of the test table at the end of testBulkLoad
should be in the finally part of a try-finally that wraps the unit test code.
Addressed.
bq. ◾testPostGrantRevoke, testPostGrantRevokeAtQualifierLevel, and
testPermissionList are still creating its own table for the test. Want to fix
that too?
Done.
{quote}
◾Changes made by testGrantRevoke, testPostGrantRevoke,
testPostGrantRevokeAtQualifierLevel, testPermissionList,
testAccessControlClientGlobalGrantRevoke,
testAccessControlClientGrantRevokeOnNamespace, testCoprocessorExec should be
cleaned up in a finally block
{quote}
For testPostGrantRevoke, testPostGrantRevokeAtQualifierLevel, and
testPermissionList as per the above comment the table will be deleted at the
end so no other explicit cleanup is required I think.
> Improve the test run time for TestAccessController class
> --------------------------------------------------------
>
> Key: HBASE-13658
> URL: https://issues.apache.org/jira/browse/HBASE-13658
> Project: HBase
> Issue Type: Sub-task
> Components: test
> Affects Versions: 0.98.12
> Reporter: Ashish Singhi
> Assignee: Ashish Singhi
> Fix For: 2.0.0, 0.98.13, 1.0.2, 1.2.0, 1.1.1
>
> Attachments: 13658.patch, HBASE-13658-v1.patch, HBASE-13658-v2.patch,
> HBASE-13658.patch
>
>
> Improve the test run time for TestAccessController class
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
