[
https://issues.apache.org/jira/browse/HBASE-13686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555907#comment-14555907
]
Hadoop QA commented on HBASE-13686:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12734757/HBASE-13686-v2.patch
against master branch at commit f8893e0012031a8c623d9da3839e757006878396.
ATTACHMENT ID: 12734757
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.tika.parser.fork.ForkParserIntegrationTest.testAttachingADebuggerOnTheForkedParserShouldWork(ForkParserIntegrationTest.java:234)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14154//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14154//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14154//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14154//console
This message is automatically generated.
> Fail to limit rate in RateLimiter
> ---------------------------------
>
> Key: HBASE-13686
> URL: https://issues.apache.org/jira/browse/HBASE-13686
> Project: HBase
> Issue Type: Bug
> Affects Versions: 2.0.0, 1.1.0
> Reporter: Guanghao Zhang
> Assignee: Ashish Singhi
> Fix For: 2.0.0, 1.2.0, 1.1.1
>
> Attachments: HBASE-13686-v1.patch, HBASE-13686-v2.patch,
> HBASE-13686.patch
>
>
> While using the patch in HBASE-11598 , I found that RateLimiter can't to
> limit the rate right.
> {code}
> /**
> * given the time interval, are there enough available resources to allow
> execution?
> * @param now the current timestamp
> * @param lastTs the timestamp of the last update
> * @param amount the number of required resources
> * @return true if there are enough available resources, otherwise false
> */
> public synchronized boolean canExecute(final long now, final long lastTs,
> final long amount) {
> return avail >= amount ? true : refill(now, lastTs) >= amount;
> }
> {code}
> When avail >= amount, avail can't be refill. But in the next time to call
> canExecute, lastTs maybe update. So avail will waste some time to refill.
> Even we use smaller rate than the limit, the canExecute will return false.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
