[jira] [Commented] (HBASE-13393) Add facility to disable tags after parent goes in

[stack (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-13393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14556590#comment-14556590
 ] 

stack commented on HBASE-13393:
-------------------------------

Simple patch but expensive.

Here is getTagsLength:

  public int getTagsLength() {
    int tagsLen = this.length - (getKeyLength() + getValueLength() + 
KEYVALUE_INFRASTRUCTURE_SIZE);
    if (tagsLen > 0) {
      // There are some Tag bytes in the byte[]. So reduce 2 bytes which is 
added to denote the tags
      // length
      tagsLen -= TAGS_LENGTH_SIZE;
    }
    return tagsLen;
  }

So, just to update (a volatile) if we have a tag, we will do all above 
parses.... Some will be cached but others we'll do per Cell.

Can we inline the update of tags count w/ some other parse we are doing on Cell 
as part of put to MemStore? Lets see if we can be smarter.

> Add facility to disable tags after parent goes in
> -------------------------------------------------
>
>                 Key: HBASE-13393
>                 URL: https://issues.apache.org/jira/browse/HBASE-13393
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: stack
>            Assignee: stack
>         Attachments: HBASE-13393.patch
>
>
> We used to specify 'no tags' by choosing to write files that were version 2.  
> After parent goes in, make it so can ask a v3 file not to write tags.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)