[
https://issues.apache.org/jira/browse/HBASE-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14558309#comment-14558309
]
Ted Yu commented on HBASE-13761:
--------------------------------
UnsafeAccess.java needs Apache license. Please add interface audience
annotation.
{code}
+ } catch (IllegalAccessException e) {
+ throw new Error();
{code}
Add message saying what caused the Error
{code}
+ if (theUnsafe.arrayIndexScale(byte[].class) != 1) {
+ throw new AssertionError();
{code}
Add message for the assertion.
{code}
86 * If won't match than we will return to the
{code}
"won't match than" -> "doesn't match then"
{code}
116 private void preprocessSearchKey(Pair<byte[], byte[]> p) {
117 byte[] key = p.getFirst();
118 byte[] mask = p.getSecond();
{code}
Indentation should be by two spaces.
{code}
164 lastFound = true;
165 lastFoundIndex = index;
{code}
Looks like lastFound can be omitted - we can use lastFoundIndex != -1 in its
place.
{code}
191 // This can happen when we have multilpe filters and some other
filter
192 // returns next row with hint which is larger (smaller for
reverse)
193 // than the current (really?)
{code}
Does any test in TestFuzzyRowFilter cover the above scenario ?
See if javadoc and checkstyle warnings are related to the patch.
> Optimize FuzzyRowFilter
> -----------------------
>
> Key: HBASE-13761
> URL: https://issues.apache.org/jira/browse/HBASE-13761
> Project: HBase
> Issue Type: Improvement
> Components: Filters
> Affects Versions: 2.0.0, 1.1.0, 0.98.13
> Reporter: Vladimir Rodionov
> Assignee: Vladimir Rodionov
> Priority: Minor
> Fix For: 2.0.0, 0.98.14, 1.1.1
>
> Attachments: HBASE-13761.patch
>
>
> FuzzyRowFilter has some room for improvements: a lot of byte-by-byte
> arithmetic, non-efficient algorithm of selecting next candidate row etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
