[ 
https://issues.apache.org/jira/browse/HBASE-13764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Singhi updated HBASE-13764:
----------------------------------
    Attachment: 13764-branch-1.patch

[~srikanth235], no problem. I have attached the patch fixing the test failure.
Please review.
Looking at test failure stack trace
{noformat}
org.apache.hadoop.hbase.TableNotDisabledException: 
org.apache.hadoop.hbase.TableNotDisabledException: testRowCounter
        at 
org.apache.hadoop.hbase.master.HMaster.checkTableModifiable(HMaster.java:1850)
        at 
org.apache.hadoop.hbase.master.procedure.TruncateTableProcedure.prepareTruncate(TruncateTableProcedure.java:252)
        at 
org.apache.hadoop.hbase.master.procedure.TruncateTableProcedure.executeFromState(TruncateTableProcedure.java:79)
        at 
org.apache.hadoop.hbase.master.procedure.TruncateTableProcedure.executeFromState(TruncateTableProcedure.java:47)
        at 
org.apache.hadoop.hbase.procedure2.StateMachineProcedure.execute(StateMachineProcedure.java:107)
        at 
org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:400)
        at 
org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:869)
        at 
org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execLoop(ProcedureExecutor.java:673)
        at 
org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execLoop(ProcedureExecutor.java:626)
        at 
org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$200(ProcedureExecutor.java:70)
        at 
org.apache.hadoop.hbase.procedure2.ProcedureExecutor$1.run(ProcedureExecutor.java:413)

        at 
org.apache.hadoop.hbase.ipc.RpcClientImpl.call(RpcClientImpl.java:1200)
        at 
org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:214)
        at 
org.apache.hadoop.hbase.ipc.AbstractRpcClient$BlockingRpcChannelImplementation.callBlockingMethod(AbstractRpcClient.java:288)
        at 
org.apache.hadoop.hbase.protobuf.generated.MasterProtos$MasterService$BlockingStub.truncateTable(MasterProtos.java:51038)
        at 
org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation$4.truncateTable(ConnectionManager.java:1778)
        at org.apache.hadoop.hbase.client.HBaseAdmin$6.call(HBaseAdmin.java:923)
        at org.apache.hadoop.hbase.client.HBaseAdmin$6.call(HBaseAdmin.java:918)
        at 
org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithRetries(RpcRetryingCaller.java:126)
        at 
org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:3917)
        at 
org.apache.hadoop.hbase.client.HBaseAdmin.truncateTable(HBaseAdmin.java:918)
        at 
org.apache.hadoop.hbase.HBaseTestingUtility.truncateTable(HBaseTestingUtility.java:1963)
        at 
org.apache.hadoop.hbase.HBaseTestingUtility.truncateTable(HBaseTestingUtility.java:1977)
        at 
org.apache.hadoop.hbase.mapreduce.TestRowCounter.testRowCounterTimeRange(TestRowCounter.java:163)
{noformat}
We should disable the table before calling truncate api. To fix the test 
instead of disabling the table I have updated the test to use 
{{deleteTableData}} method to keep it consistent with master branch code.

> Backport HBASE-7782 (HBaseTestingUtility.truncateTable() not acting like CLI) 
> to branch-1.x
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13764
>                 URL: https://issues.apache.org/jira/browse/HBASE-13764
>             Project: HBase
>          Issue Type: Task
>    Affects Versions: 1.2.0
>            Reporter: Srikanth Srungarapu
>            Assignee: Ashish Singhi
>            Priority: Minor
>         Attachments: 13764-branch-1.patch, HBASE-13764-branch-1.patch
>
>
> Backport this test infrastructure improvement, which makes 
> {{truncateTable()}} in HBaseTestingUtility behave in the same way it's CLI 
> counterpart. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to