[ 
https://issues.apache.org/jira/browse/HBASE-13777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14560773#comment-14560773
 ] 

Hadoop QA commented on HBASE-13777:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12735551/0001-HBASE-13777-Table-fragmentation-display-triggers-NPE.patch
  against master branch at commit c8c23cc3183735b02e9f43bf7115d9ce3cd2a880.
  ATTACHMENT ID: 12735551

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +        <td><a href=table.jsp?name=<% tableName.getNameAsString() %>><% 
tableName.getQualifierAsString() %></a> </td>
+            <td align="center"><% frags.get(tableName.getNameAsString()) != 
null ? frags.get(tableName.getNameAsString()).intValue() + "%" : "n/a" %></td>

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14196//testReport/
Release Findbugs (version 2.0.3)        warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14196//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14196//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14196//console

This message is automatically generated.

> Table fragmentation display triggers NPE on master status page
> --------------------------------------------------------------
>
>                 Key: HBASE-13777
>                 URL: https://issues.apache.org/jira/browse/HBASE-13777
>             Project: HBase
>          Issue Type: Bug
>          Components: UI
>    Affects Versions: 1.1.0
>            Reporter: Lars George
>            Assignee: Lars George
>              Labels: beginner
>             Fix For: 2.0.0, 1.0.2, 1.2.0, 1.1.1
>
>         Attachments: 
> 0001-HBASE-13777-Table-fragmentation-display-triggers-NPE.patch
>
>
> Steps to reproduce:
> - Enable UI support for Fragmentation
> {noformat}
>   <property>
>     <name>hbase.master.ui.fragmentation.enabled</name>
>     <value>true</value>
>   </property>
> {noformat}
> Make sure to restart HBase.
> - Create NSes and table
> {noformat}
> hbase(main):004:0> create_namespace 'testqauat'
> 0 row(s) in 0.0370 seconds
> hbase(main):005:0> create_namespace 'financedept'
> 0 row(s) in 0.0100 seconds
> hbase(main):006:0> create_namespace 'engdept'
> 0 row(s) in 0.0090 seconds
> hbase(main):007:0> create 'testqauat:testtable', 'cf1'
> 0 row(s) in 1.2590 seconds
> => Hbase::Table - testqauat:testtable
> hbase(main):008:0> for i in 'a'..'z' do for j in 'a'..'z' do put 
> 'testqauat:testtable', "row-#{i}#{j}", "cf1:#{j}", "#{j}" end end
> {noformat}
> - Reload the master UI page and you get:
> {noformat}
> HTTP ERROR 500
> Problem accessing /master-status. Reason:
>     INTERNAL_SERVER_ERROR
> Caused by:
> java.lang.NullPointerException
>       at 
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmplImpl.__jamon_innerUnit__userTables(MasterStatusTmplImpl.java:685)
>       at 
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmplImpl.renderNoFlush(MasterStatusTmplImpl.java:268)
>       at 
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.renderNoFlush(MasterStatusTmpl.java:377)
>       at 
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.render(MasterStatusTmpl.java:368)
>       at 
> org.apache.hadoop.hbase.master.MasterStatusServlet.doGet(MasterStatusServlet.java:81)
> ...
> {noformat}
> Note that the table.jsp page works fine, just the master page fails.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to