[ 
https://issues.apache.org/jira/browse/HBASE-13796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564056#comment-14564056
 ] 

Hadoop QA commented on HBASE-13796:
-----------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12735973/HBASE-13796.patch
  against master branch at commit 4aa7209826ae42e47089fd20747d014183fccb6f.
  ATTACHMENT ID: 12735973

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 4 new 
or modified tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14223//testReport/
Release Findbugs (version 2.0.3)        warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14223//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14223//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14223//console

This message is automatically generated.

> ZKUtil doesn't clean quorum setting properly
> --------------------------------------------
>
>                 Key: HBASE-13796
>                 URL: https://issues.apache.org/jira/browse/HBASE-13796
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.0.1, 1.1.0, 0.98.12
>            Reporter: Geoffrey Jacoby
>            Assignee: Geoffrey Jacoby
>            Priority: Minor
>         Attachments: HBASE-13796.patch
>
>
> ZKUtil.getZooKeeperClusterKey is obviously trying to pull out the ZooKeeper 
> quorum setting from the config object and remove several special characters 
> from it. Due to a misplaced parenthesis, however, it's instead running the 
> replace operation on the config setting _name_, HConstants.ZOOKEEPER_QUORUM, 
> and not the config setting itself. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to