[
https://issues.apache.org/jira/browse/HBASE-13800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564096#comment-14564096
]
Hadoop QA commented on HBASE-13800:
-----------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12735995/HBASE-13800.patch
against master branch at commit 4aa7209826ae42e47089fd20747d014183fccb6f.
ATTACHMENT ID: 12735995
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14226//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14226//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14226//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14226//console
This message is automatically generated.
> TestStore#testDeleteExpiredStoreFiles should create different data/log
> directory for each call
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-13800
> URL: https://issues.apache.org/jira/browse/HBASE-13800
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 2.0.0, 1.1.0, 1.2.0
> Environment: Windows
> Reporter: Stephen Yuan Jiang
> Assignee: Stephen Yuan Jiang
> Priority: Minor
> Attachments: HBASE-13800.patch
>
>
> When TestStore#init() was called twice in
> TestStore#testDeleteExpiredStoreFiles, it did not use different base
> directory for each call (other tests in the same test suite do). If the
> first call did not release the handle of WAL files fast enough, the second
> init() call would fail.
> This is constantly seen in Windows environment:
> {noformat}
> java.io.IOException: Target WAL already exists within directory
> file:/C:/hbase/hbase-server/target/test-data/f39ecdde-1d04-4332-93c7-4c8df1e08e67/TestStoretestDeleteExpiredStoreFiles/WALs/testDeleteExpiredStoreFiles
> at
> org.apache.hadoop.hbase.regionserver.wal.FSHLog.<init>(FSHLog.java:525)
> at
> org.apache.hadoop.hbase.wal.DefaultWALProvider.init(DefaultWALProvider.java:97)
> at
> org.apache.hadoop.hbase.wal.WALFactory.getProvider(WALFactory.java:147)
> at org.apache.hadoop.hbase.wal.WALFactory.<init>(WALFactory.java:179)
> at
> org.apache.hadoop.hbase.regionserver.TestStore.init(TestStore.java:185)
> at
> org.apache.hadoop.hbase.regionserver.TestStore.init(TestStore.java:162)
> at
> org.apache.hadoop.hbase.regionserver.TestStore.testDeleteExpiredStoreFiles(TestStore.java:307)
> at
> org.apache.hadoop.hbase.regionserver.TestStore.testDeleteExpiredStoreFiles(TestStore.java:286)
> {noformat}
> The fix is trivial: just like other tests in the same test suite, use
> different base directory for multiple init() calls in the same test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
