[
https://issues.apache.org/jira/browse/HBASE-13807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564910#comment-14564910
]
Hadoop QA commented on HBASE-13807:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12736122/HBASE-13807-0.98.patch
against 0.98 branch at commit cca687d718df9c8580820292e309275e30a4111d.
ATTACHMENT ID: 12736122
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
25 warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14235//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14235//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14235//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14235//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14235//console
This message is automatically generated.
> [0.98] NoTagsKeyValue optimization is not proper
> ------------------------------------------------
>
> Key: HBASE-13807
> URL: https://issues.apache.org/jira/browse/HBASE-13807
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.98.13
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Fix For: 0.98.14
>
> Attachments: HBASE-13807-0.98.patch
>
>
> When the file format is V2, it has no support for tags and so cells will be
> with 0 tags length. For such cells we make NoTagsKeyValue which avoid
> getTagsLength parsing overhead in KeyValue. Still HFileReaderV2 creates
> KeyValue.
> This is a 0.98 issue only.
> Also in case of DBE, we can consider the tags length and return
> KeyValue/NoTagsKeyValue
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
