[
https://issues.apache.org/jira/browse/HBASE-13356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566923#comment-14566923
]
Ted Yu commented on HBASE-13356:
--------------------------------
Looks pretty good.
Minor comments:
{code}
+ * MultiTableSnapshotInputFormat generalizes {@link
org.apache.hadoop.hbase.mapred
+ * .TableSnapshotInputFormat}
{code}
Better put '{@link ' on second line so that the class name is on same line.
In MultiTableSnapshotInputFormatImpl :
{code}
+ // TODO: these probably belong elsewhere/may already be implemented
elsewhere.
+
{code}
The above can be removed, right ?
> HBase should provide an InputFormat supporting multiple scans in mapreduce
> jobs over snapshots
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-13356
> URL: https://issues.apache.org/jira/browse/HBASE-13356
> Project: HBase
> Issue Type: New Feature
> Components: mapreduce
> Reporter: Andrew Mains
> Assignee: Andrew Mains
> Priority: Minor
> Attachments: HBASE-13356-0.98.patch, HBASE-13356.2.patch,
> HBASE-13356.3.patch, HBASE-13356.4.patch, HBASE-13356.patch
>
>
> Currently, HBase supports the pushing of multiple scans to mapreduce jobs
> over live tables (via MultiTableInputFormat) but only supports a single scan
> for mapreduce jobs over table snapshots. It would be handy to support
> multiple scans over snapshots as well, probably through another input format
> (MultiTableSnapshotInputFormat?). To mimic the functionality present in
> MultiTableInputFormat, the new input format would likely have to take in the
> names of all snapshots used in addition to the scans.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
