[ 
https://issues.apache.org/jira/browse/HBASE-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14570518#comment-14570518
 ] 

Ashish Singhi commented on HBASE-13829:
---------------------------------------

Patch looks ok to me.
bq. The request(read/write) limit can be expressed using the form 100req/sec, 
100req/min
Can we explain this more in detail to the hbase shell user that he/she can 
either set quota on read, write or on both the requests together(i.e., read + 
write).

Also can you add a unit test where quota is set on read_num and assert that 
there will be no quota control on the write_num requests.

> Add more ThrottleType
> ---------------------
>
>                 Key: HBASE-13829
>                 URL: https://issues.apache.org/jira/browse/HBASE-13829
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client
>            Reporter: Guanghao Zhang
>            Assignee: Guanghao Zhang
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13829.patch
>
>
> HBASE-11598 add simple throttling for hbase. But in the client, it doesn't 
> support user to set ThrottleType like WRITE_NUM, WRITE_SIZE, READ_NUM, 
> READ_SIZE.
> REVIEW BOARD: https://reviews.apache.org/r/34989/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to