[
https://issues.apache.org/jira/browse/HBASE-12295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14572232#comment-14572232
]
Hadoop QA commented on HBASE-12295:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12737459/HBASE-12295_1.patch
against master branch at commit bb62d5b2e8db1677568723bb8d0d8ea4fd2c6f46.
ATTACHMENT ID: 12737459
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 53 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
1936 checkstyle errors (more than the master's current 1920 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ cellScanner = IPCUtil.getInstance().createCellScanner(codec,
compressor, bb.array(), 0, bb.limit());
+ * read data from such cache, we will make a cell referring to the same memory
and will avoid any copy.
+ * Cell. This is useful when we want to consume the Cell before even the
block referring to these cells
+ * done with this instance by calling {@link #flipAndReturnBuffer()}. All
this encapsulation violation
+ if (block != null && this.curBlock != null && block.getOffset() ==
this.curBlock.getOffset()) {
+ // Ideally if we can make the scanner to work at this level it is much
easier because this method
+ // surely knows what was fetched from the cache and based on that we
could keep returning the prev
+ + " readers. Can not be freed now. Hence will mark this for
evicting at a later point");
+ Triple<Message, CellScanner, ByteBuffer> call(BlockingService service,
MethodDescriptor md, Message param,
+ //((PayloadCarryingRpcController)
controller).setCellScanner(CellUtil.createCellScanner(results));
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestKeyValueHeap
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14279//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14279//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14279//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14279//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14279//console
This message is automatically generated.
> Prevent block eviction under us if reads are in progress from the BBs
> ---------------------------------------------------------------------
>
> Key: HBASE-12295
> URL: https://issues.apache.org/jira/browse/HBASE-12295
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver, Scanners
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 2.0.0
>
> Attachments: HBASE-12295.pdf, HBASE-12295_1.patch, HBASE-12295_1.pdf,
> HBASE-12295_trunk.patch
>
>
> While we try to serve the reads from the BBs directly from the block cache,
> we need to ensure that the blocks does not get evicted under us while
> reading. This JIRA is to discuss and implement a strategy for the same.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
