[
https://issues.apache.org/jira/browse/HBASE-13451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ramkrishna.s.vasudevan updated HBASE-13451:
-------------------------------------------
Attachment: HBASE-13451_3.patch
Addresses review comments from Stack. Minor changes from the previous patches.
[[email protected]]
Thanks for the review. I verified every method in the BlockIndexreader and
they have sufficient coverage. TestHFile, TestHfileWriterV2 and V3, TestSeekTo,
TestcompoundBloomFilter addresses the coverage part.
Regarding changing the scope to package private, I doubt it cannot be done
because the BlockIndexReader is used in CompoundBloomFilter used in util
package.
> Make the HFileBlockIndex blockKeys to Cells so that it could be easy to use
> in the CellComparators
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-13451
> URL: https://issues.apache.org/jira/browse/HBASE-13451
> Project: HBase
> Issue Type: Sub-task
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 2.0.0
>
> Attachments: HBASE-13451.patch, HBASE-13451_1.patch,
> HBASE-13451_2.patch, HBASE-13451_3.patch
>
>
> After HBASE-10800 we could ensure that all the blockKeys in the BlockReader
> are converted to Cells (KeyOnlyKeyValue) so that we could use
> CellComparators. Note that this can be done only for the keys that are
> written using CellComparators and not for the ones using RawBytesComparator.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
