[
https://issues.apache.org/jira/browse/HBASE-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14576092#comment-14576092
]
Guanghao Zhang commented on HBASE-13829:
----------------------------------------
Thank you very much for your review. I want modify the doc in a new issue, so
forgot it in this patch. I will take your advice and add it in the next update
of this patch.
bq. Even I prefer the same when client reduces the limit lets not touch the
current available resources. Did you find any issue with the existing code ?
If we set quota just for read number, then the avail of write number will be
Long.MAX_VALUE. Then we set quota for write number, but the avail will be
always the Long.MAX_VALUE, because the new limit is smaller than the old limit
(Long.MAX_VALUE). As you know, the patch of HBASE-13686 have not be committed.
So the refill bug will cause the canExecute() always return true. So the quota
of write number will not work.
> Add more ThrottleType
> ---------------------
>
> Key: HBASE-13829
> URL: https://issues.apache.org/jira/browse/HBASE-13829
> Project: HBase
> Issue Type: Improvement
> Components: Client
> Reporter: Guanghao Zhang
> Assignee: Guanghao Zhang
> Fix For: 2.0.0
>
> Attachments: HBASE-13829-v1.patch, HBASE-13829.patch
>
>
> HBASE-11598 add simple throttling for hbase. But in the client, it doesn't
> support user to set ThrottleType like WRITE_NUM, WRITE_SIZE, READ_NUM,
> READ_SIZE.
> REVIEW BOARD: https://reviews.apache.org/r/34989/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
