[
https://issues.apache.org/jira/browse/HBASE-13873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14580105#comment-14580105
]
Hadoop QA commented on HBASE-13873:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12738735/HBASE-13873-0.98.patch
against 0.98 branch at commit 4713fc6407450825b1907c833ca60d0cc604b5be.
ATTACHMENT ID: 12738735
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
25 warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14359//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14359//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14359//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14359//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14359//console
This message is automatically generated.
> LoadTestTool addAuthInfoToConf throws UnsupportedOperationException
> -------------------------------------------------------------------
>
> Key: HBASE-13873
> URL: https://issues.apache.org/jira/browse/HBASE-13873
> Project: HBase
> Issue Type: Bug
> Components: integration tests
> Affects Versions: 0.98.13
> Reporter: sunyerui
> Assignee: sunyerui
> Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.1
>
> Attachments: HBASE-13873-0.98.patch
>
>
> When run IntegrationTestIngestWithACL on distributed clusters with kerberos
> security enabled, the method addAuthInfoToConf() in LoadTestTool will be
> invoked and throws UnsupportedOperationException, stack as follows:
> {code}
> 2015-06-09 22:15:33,605 ERROR [main] util.AbstractHBaseTool: Error running
> command-line tool
> java.lang.UnsupportedOperationException
> at java.util.AbstractList.add(AbstractList.java:148)
> at java.util.AbstractList.add(AbstractList.java:108)
> at
> org.apache.hadoop.hbase.util.LoadTestTool.addAuthInfoToConf(LoadTestTool.java:811)
> at
> org.apache.hadoop.hbase.util.LoadTestTool.loadTable(LoadTestTool.java:516)
> at
> org.apache.hadoop.hbase.util.LoadTestTool.doWork(LoadTestTool.java:479)
> at
> org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:112)
> at
> org.apache.hadoop.hbase.IntegrationTestIngest.runIngestTest(IntegrationTestIngest.java:151)
> at
> org.apache.hadoop.hbase.IntegrationTestIngest.internalRunIngestTest(IntegrationTestIngest.java:114)
> at
> org.apache.hadoop.hbase.IntegrationTestIngest.runTestFromCommandLine(IntegrationTestIngest.java:97)
> at
> org.apache.hadoop.hbase.IntegrationTestBase.doWork(IntegrationTestBase.java:115)
> at
> org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:112)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at
> org.apache.hadoop.hbase.IntegrationTestIngestWithACL.main(IntegrationTestIngestWithACL.java:136)
> {code}
> The corresponding code is below and the reason is obvious. Arrays.asList
> return a java.util.Arrays$ArrayList but not java.util.ArrayList. Both of them
> are inherited from java.util.AbstractList, but the former didn't override the
> method add(), so the parent method java.util.AbstractList.add() will be
> invoked and the exception threw.
> {code}
> private void addAuthInfoToConf(Properties authConfig, Configuration conf,
> String owner,
> String userList) throws IOException {
> List<String> users = Arrays.asList(userList.split(","));
> users.add(owner);
> ...
> }
> {code}
> Does anyone occurred on this? I think it's an obvious bug but no one report
> it, so please tell me if I misunderstanding it. If it's actually a bug here,
> then it can be fixed very easy as below:
> {code}
> List<String> users = new
> ArrayList<String>(Arrays.asList(userList.split(",")));
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
