[ https://issues.apache.org/jira/browse/HBASE-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125576#comment-13125576 ]
Ted Yu commented on HBASE-4558: ------------------------------- Patch looks good. {code} + // Should not invoke assignmentmanager.regionOnline. If it invokes as per + // the + // current mocking we have done it will throw null pointer. {code} 'the' in the middle is not needed. How about the following ? {code} + // Should not invoke assignmentmanager.regionOnline. If it is invoked as per + // current mocking it will throw null pointer exception. {code} > Refactor TestOpenedRegionHandler and TestOpenRegionHandler. > ----------------------------------------------------------- > > Key: HBASE-4558 > URL: https://issues.apache.org/jira/browse/HBASE-4558 > Project: HBase > Issue Type: Improvement > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Priority: Minor > Fix For: 0.92.0 > > Attachments: HBASE-4558_1.patch > > > This is an improvement task taken up to refactor TestOpenedRegionandler and > TestOpenRegionHandler so that MockServer and MockRegionServerServices can be > accessed from a common utility package. > If we do this then one of the testcases in TestOpenedRegionHandler need not > start up a cluster and also moving it into a common package will help in > mocking the server for future testcases. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira