[
https://issues.apache.org/jira/browse/HBASE-13897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14587261#comment-14587261
]
Ted Yu commented on HBASE-13897:
--------------------------------
bq. -1 InterfaceAudience. The patch appears to contain InterfaceAudience from
hadoop rather than hbase:
Please use the following:
{code}
import org.apache.hadoop.hbase.classification.InterfaceAudience;
import org.apache.hadoop.hbase.classification.InterfaceStability;
{code}
Wrap long line:
{code}
+ public static class KeyValueWritableComparablePartitioner extends
Partitioner<KeyValueWritableComparable, KeyValue> {
{code}
{code}
+ public int compareTo(KeyValueWritableComparable o) {
+ return KeyValue.COMPARATOR.compare(this.kv,
((KeyValueWritableComparable)o).kv);
+ }
{code}
Should we check o against null before casting ?
{code}
+ } catch (IOException e) {
+ e.printStackTrace();
{code}
Please drop 'e.printStackTrace()'
{code}
- if (CellUtil.isDeleteFamily(kv)) {
- Delete deleteFamily = new Delete(key.get());
{code}
Where is the above case handled ?
Please check failure in TestImportExport
> OOM occurs when Import importing a row that including too much KeyValue
> ------------------------------------------------------------------------
>
> Key: HBASE-13897
> URL: https://issues.apache.org/jira/browse/HBASE-13897
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.98.13
> Reporter: Liu Junhong
> Assignee: Ted Yu
> Fix For: 0.98.13
>
> Attachments: HBASE-13897-0.98.patch
>
>
> When importing a row with too many KeyValues (may have too many columns or
> versions)，KeyValueReducer will incur OOM.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
