[
https://issues.apache.org/jira/browse/HBASE-13214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14590842#comment-14590842
]
Mikhail Antonov commented on HBASE-13214:
-----------------------------------------
Good cleanup! Good to see HTable getting 400 lines shorter as result :)
Do we not need this? I kind of remember discussion ([~larsgeorge]?) about
accessing internal write buffer. Will try to find, but seems we can just remove
it.
{code}
/**
* Kept in 0.96 for backward compatibility
* @deprecated since 0.96. This is an internal buffer that should not be
read nor write.
*/
@Deprecated
public List<Row> getWriteBuffer() {
return mutator == null ? null : mutator.getWriteBuffer();
}
{code}
Now it looks like there's bunch of unused/deprecated method in HTableInterface,
but this class is going (I believe) to be deleted anyway, so no need to fix
those.
Small nits - there's some unused imports in OfflineMetaRebuildTestCore,
TestMasterObserver, some unnecessary initializations in TestAdmin1.
Looks good otherwise. Let's see what hadoop-qa says. Regarding RB upload - how
do you produce patch? I usually commit it locally, then do 'git format-patch
HEAD^..HEAD --stdout > patch.name', and then just do soft/hard reset as needed.
> Remove deprecated and unused methods from HTable class
> ------------------------------------------------------
>
> Key: HBASE-13214
> URL: https://issues.apache.org/jira/browse/HBASE-13214
> Project: HBase
> Issue Type: Sub-task
> Components: API
> Affects Versions: 2.0.0
> Reporter: Mikhail Antonov
> Assignee: Ashish Singhi
> Fix For: 2.0.0
>
> Attachments: HBASE-13214.patch
>
>
> Methods like #getRegionLocation(), #isTableEnabled() etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
