[
https://issues.apache.org/jira/browse/HBASE-13893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jurriaan Mous updated HBASE-13893:
----------------------------------
Attachment: HBASE-13893-v5.patch
I have reverted the change to getHTable in TIFB. I should not have changed that
since it were already deprecated methods. It does not need a setTable since the
deprecation of setHTable already point to another alternative with TableName.
I have reverted the createTable changes and added deprecation warnings. I would
like to do a new issue with only the signature changes to return Table for
2.0/master branch. Otherwise I cannot support Client side tests for Async Table
implementation. I will make that issue and patch after this patch lands and I
will also await what the result of the mailinglist discussion is.
{quote}
In TestFromClientSide, there is this:
if (t instanceof HTable){
and ....
if (t instanceof HTableInterface) {
Later, there'll be a if (t instanceof AsyncTable) ?
{quote}
These tests only test HTable specific functionality like buffers and
getRowOrBefore which I can't test with an Async TableImpl. So that is why it
has the instanceof check. There is no need to add AsyncTable variants since the
functionality is in the deprecated HTableInterface and is replaced with
BufferedMutator and Reversed Scans. Maybe we could move those specific tests
out of TestFromClientSide to a specific HTable only test when I add the
parameterized test.
> Replace HTable with Table in client tests
> -----------------------------------------
>
> Key: HBASE-13893
> URL: https://issues.apache.org/jira/browse/HBASE-13893
> Project: HBase
> Issue Type: Bug
> Components: Client, test
> Reporter: Jurriaan Mous
> Assignee: Jurriaan Mous
> Attachments: HBASE-13893-v1.patch, HBASE-13893-v2.patch,
> HBASE-13893-v3.patch, HBASE-13893-v3.patch, HBASE-13893-v4.patch,
> HBASE-13893-v5.patch, HBASE-13893.patch
>
>
> Many client tests reference the HTable implementation instead of the generic
> Table implementation. It is now not possible to reuse the tests for another
> Table implementation. This issue focusses on all HTable instances in relevant
> client tests and thus not all HTable instances.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
