[ 
https://issues.apache.org/jira/browse/HBASE-13931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14593232#comment-14593232
 ] 

Anoop Sam John commented on HBASE-13931:
----------------------------------------

There is one point to discuss
{code}
+   * @deprecated As of release 2.0.0, this will be removed in HBase 3.0.0.
    */
+  @Deprecated
   public static long toLongUnsafe(byte[] bytes, int offset) {
{code}
Actually we can remove this method from bytes. Users can use toLong() method 
and it will internally use unsafe if it is available.  But this was provided as 
a public method in Bytes which is Public InterfaceAudience.  So not removing 
the method but deprecating it with out any replacement.

> Move Unsafe based operations to UnsafeAccess
> --------------------------------------------
>
>                 Key: HBASE-13931
>                 URL: https://issues.apache.org/jira/browse/HBASE-13931
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13931.patch, HBASE-13931_V2.patch
>
>
> We have this new class added. Bytes.java having unsafe based reads in it. Now 
> HBASE-13916 will add similar unsafe based reads (on BB) in ByteBufferUtils.  
> We can move the unsafe based operations to UnsafeAccess and otehr places just 
> refer to here.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to