[ 
https://issues.apache.org/jira/browse/HBASE-13926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595085#comment-14595085
 ] 

Hudson commented on HBASE-13926:
--------------------------------

FAILURE: Integrated in HBase-TRUNK #6586 (See 
[https://builds.apache.org/job/HBase-TRUNK/6586/])
HBASE-13926 Close the scanner only after Call#setResponse. (anoopsamjohn: rev 
e4d8fab104d6c4edc8721ee14238fcc59bd203d0)
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/KeyValueScanner.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcCallback.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/KeyValueHeap.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Shipper.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScanner.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileScanner.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/NonLazyKeyValueScanner.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcCallContext.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Leases.java


> Close the scanner only after Call#setResponse
> ---------------------------------------------
>
>                 Key: HBASE-13926
>                 URL: https://issues.apache.org/jira/browse/HBASE-13926
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13926.patch, HBASE-13926_V2.patch, 
> HBASE-13926_V2.patch, HBASE-13926_V3.patch
>
>
> This is for HBASE-12295. We will be delivering cells directly from shared 
> cache memory. HBASE-12295 adds a ref count based prevention mechanism to 
> avoid block eviction, when that memory area in use by scanners. We will 
> decrement ref count at scanner close. The memory area will be in use till a 
> cellblock is created or PB scan reply message is built. So we can delay the 
> close of the scanner until the response is set for the scanner Call. This is 
> done via a RpcCallback way. The callback is set on Call at scan time. Once 
> the setResponse is done, the Call will execute the RpcCallback.
> This jira also adds a facility to do some cleanup/close during the course of 
> scan. Scan from client makes many RPCs fetching N rows each time. Only at the 
> end the scanner close will happen. We will add a new batchClose() facility 
> with which we can do any cleanup after every rpc call is executed and rows 
> fetched for return.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to