[
https://issues.apache.org/jira/browse/HBASE-4410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126286#comment-13126286
]
Jonathan Gray commented on HBASE-4410:
--------------------------------------
My comeback is that Lars is right and I f-ed it up. I was supposed to make a
new patch but forgot about this. I was a bit angry I came up with such a nice
elegant solution that was fundamentally broken. ;)
Will try to get to this next week.
> FilterList.filterKeyValue can return suboptimal ReturnCodes
> -----------------------------------------------------------
>
> Key: HBASE-4410
> URL: https://issues.apache.org/jira/browse/HBASE-4410
> Project: HBase
> Issue Type: Improvement
> Components: filters
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4410-v1.patch
>
>
> FilterList.filterKeyValue does not always return the most optimal ReturnCode
> in both the AND and OR conditions.
> For example, if you have F1 AND F2, F1 returns SKIP. It immediately returns
> the SKIP. However, if F2 would have returned NEXT_COL or NEXT_ROW or
> SEEK_NEXT_USING_HINT, we would actually be able to return the more optimal
> ReturnCode from F2.
> For AND conditions, we can always pick the *most restrictive* return code.
> For OR conditions, we must always pick the *least restrictive* return code.
> This JIRA is to review the FilterList.filterKeyValue() method to try and make
> it more optimal and to add a new unit test which verifies the correct
> behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
