[ 
https://issues.apache.org/jira/browse/HBASE-13906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597393#comment-14597393
 ] 

Hadoop QA commented on HBASE-13906:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12741228/HBASE-13906-branch-1.v1.patch
  against branch-1 branch at commit 6a537eb8545c7dd6c01c0d911ad12e789eeab3ae.
  ATTACHMENT ID: 12741228

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

     {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s):       
at 
org.apache.activemq.broker.BrokerRedeliveryTest.testInfiniteRedelivery(BrokerRedeliveryTest.java:54)

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14524//testReport/
Release Findbugs (version 2.0.3)        warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14524//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14524//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14524//console

This message is automatically generated.

> Improve handling of NeedUnmanagedConnectionException
> ----------------------------------------------------
>
>                 Key: HBASE-13906
>                 URL: https://issues.apache.org/jira/browse/HBASE-13906
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.0.0, 1.1.0
>            Reporter: Nick Dimiduk
>            Assignee: Mikhail Antonov
>             Fix For: 1.2.0, 1.3.0
>
>         Attachments: HBASE-13906-branch-1.v1.patch, 
> HBASE-13906-branch-1.v1.patch, HBASE-13906-branch-1.v1.patch
>
>
> During my investigation of HBASE-13833, I made this 
> [comment|https://issues.apache.org/jira/browse/HBASE-13833?focusedCommentId=14585302&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14585302]
> {quote}
> One other thing: should we somehow handle NeedUnmanagedConnectionException 
> similarly to DoNotRetryIOException? It's too late to wire them up thusly, but 
> for the case of bulk load when the bug is expressed, we go through the full 
> 35x retry loop before eventually failing the RPC. This would be applicable to 
> branch-1.
> {quote}
> This would apply only to branch-1 as master no longer has unmanaged 
> connections. Probably we cannot change the inheritance hierarchy due to 
> compatibility guarantees, but maybe we can do something like everywhere we 
> look for DNRIOE, we do the same for NUCE.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to