[
https://issues.apache.org/jira/browse/HBASE-13961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599595#comment-14599595
]
Hadoop QA commented on HBASE-13961:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12741574/HBASE-13961-0.98-v1.patch
against 0.98 branch at commit b7f241d73b79ec22db2c03cb6b384b76185f0f85.
ATTACHMENT ID: 12741574
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.3.0 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
24 warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14542//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14542//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14542//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14542//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14542//console
This message is automatically generated.
> SnapshotManager#initialize should set snapshotLayoutVersion if it allows to
> create snapshot with old layout format
> ------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-13961
> URL: https://issues.apache.org/jira/browse/HBASE-13961
> Project: HBase
> Issue Type: Improvement
> Components: snapshots
> Affects Versions: 0.98.13
> Reporter: cuijianwei
> Priority: Minor
> Attachments: HBASE-13961-0.98-v1.patch
>
>
> In 0.98, it seems the snapshot layout version could be configured by
> "hbase.snapshot.format.version". However, SnapshotManager does not set
> snapshotLayoutVersion in its initialize(...) method so that it always creates
> snapshot with latest layout format even when "hbase.snapshot.format.version"
> is set to SnapshotManifestV1.DESCRIPTOR_VERSION in configuration.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
