[
https://issues.apache.org/jira/browse/HBASE-13969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601712#comment-14601712
]
Ted Yu commented on HBASE-13969:
--------------------------------
lgtm
Minor comment:
{code}
2238 if (authTokenSecretMgr != null) {
2239 authTokenSecretMgr.stop();
2240 }
{code}
Set authTokenSecretMgr to null in the above if block after calling stop().
> AuthenticationTokenSecretManager is never stopped in RPCServer
> --------------------------------------------------------------
>
> Key: HBASE-13969
> URL: https://issues.apache.org/jira/browse/HBASE-13969
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.98.13
> Reporter: Pankaj Kumar
> Assignee: Pankaj Kumar
> Priority: Minor
> Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.2, 1.3.0
>
> Attachments: HBASE-13969.patch
>
>
> AuthenticationTokenSecretManager is never stopped in RPCServer.
> {code}
> AuthenticationTokenSecretManager mgr = createSecretManager();
> if (mgr != null) {
> setSecretManager(mgr);
> mgr.start();
> }
> {code}
> It should be stopped during exit.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
