[
https://issues.apache.org/jira/browse/HBASE-13214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14602568#comment-14602568
]
Ashish Singhi commented on HBASE-13214:
---------------------------------------
Thanks again for looking into this.
[~stack]
{quote}
I don't think you can purge getStartKeys In 1.0 branch I don't see it
deprecated (it is deprecated in branch-1.1). Maybe I am reading it wrong – I am
not seeing how they were deprecated in 1.0. Ditto getEndKeys ... and
getStartEndKeys.
{quote}
No, you are reading it correct these methods were deprecated in 1.1. But what I
have understood from the below point taken from Semantic Versioning is
{noformat}
issue a new minor release with the deprecation in place. Before you completely
remove the functionality in a new major release there should be at least one
minor release that contains the deprecation so that users can smoothly
transition to the new API.
{noformat}
We had it deprecated in 1.2, 1.3 so we can remove it in 2.0 right ?
Also HTable is annotated with @InterfaceAudience.Private and from hbase book I
understood that we can safely remove it
{noformat}
@InterfaceAudience.Private
APIs for HBase internals developers. No guarantees on compatibility or
availability in future versions. Private interfaces do not need an
@InterfaceStability classification.
{noformat}
Correct me if I am wrong with my understanding on this ?
{quote}
batch( is not @deprecated in 1.0 if I read it right. Same for exists( .... oh,
nvm, I see deprecated in the Interface. That is fine.
{quote}
I see them deprecated in 1.0 HTable code also. But anyways as you said it is
deprecated in interface also so I removed it from Table class also.
{quote}
Where is below deprecated:
public Object[] batch(List<? extends Row> actions) throws IOException {
{quote}
This was deprecated with HBASE-10347 and is available in 1.0 also.
bq. Very nice cleanup.
Thanks
> Remove deprecated and unused methods from HTable class
> ------------------------------------------------------
>
> Key: HBASE-13214
> URL: https://issues.apache.org/jira/browse/HBASE-13214
> Project: HBase
> Issue Type: Sub-task
> Components: API
> Affects Versions: 2.0.0
> Reporter: Mikhail Antonov
> Assignee: Ashish Singhi
> Fix For: 2.0.0
>
> Attachments: HBASE-13214-v1.patch, HBASE-13214-v2-again-v1.patch,
> HBASE-13214-v2-again.patch, HBASE-13214-v2.patch, HBASE-13214-v3.patch,
> HBASE-13214-v3.patch, HBASE-13214.patch
>
>
> Methods like #getRegionLocation(), #isTableEnabled() etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
